hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12557) Add information in BUILDING.txt about the need for the FINDBUGS_HOME environment variable for docs builds.
Date Sun, 08 Nov 2015 15:01:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995656#comment-14995656
] 

Allen Wittenauer commented on HADOOP-12557:
-------------------------------------------

bq. Should really findbugs details be part of distro in anyway?

That's exactly what I meant by remove. I guess folks didn't understand what "before test-patch"
meant either.. the only way hadoop committers got findbugs output was *after* doing a full
dist build back in the 0.x days.  There was no test-patch to do findbugs analysis during patch
review!

This is a great example of everyone reading code and assuming it is actually correct. :D 
But once you take a step back, you realize that it completely bonkers to be putting findbugs
output in the distribution documentation.  

> Add information in BUILDING.txt about the need for the FINDBUGS_HOME environment variable
for docs builds.
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12557
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12557
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 2.7.1
>            Reporter: Chris Nauroth
>            Assignee: huangzheng
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-12557.patch
>
>
> BUILDING.txt mentions Findbugs 1.3.9 as a requirement, but it doesn't mention that the
{{FINDBUGS_HOME}} environment variable must point to the base directory of the Findbugs installation
when running builds with {{-Pdocs}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message