From common-issues-return-101705-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org Thu Jan 7 09:50:41 2016 Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 21E7E183FF for ; Thu, 7 Jan 2016 09:50:41 +0000 (UTC) Received: (qmail 90735 invoked by uid 500); 7 Jan 2016 09:50:40 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 90428 invoked by uid 500); 7 Jan 2016 09:50:40 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 90222 invoked by uid 99); 7 Jan 2016 09:50:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jan 2016 09:50:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D1A9A2C14F4 for ; Thu, 7 Jan 2016 09:50:39 +0000 (UTC) Date: Thu, 7 Jan 2016 09:50:39 +0000 (UTC) From: "Akihiro Suda (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-12693) Many misusages of assertEquals(expected, actual) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akihiro Suda updated HADOOP-12693: ---------------------------------- Summary: Many misusages of assertEquals(expected, actual) (was: Many misusage of assertEquals(expected, actual)) > Many misusages of assertEquals(expected, actual) > ------------------------------------------------ > > Key: HADOOP-12693 > URL: https://issues.apache.org/jira/browse/HADOOP-12693 > Project: Hadoop Common > Issue Type: Test > Reporter: Akihiro Suda > Priority: Trivial > Attachments: just-rough-approx.txt > > > The first arg of {{org.JUnit.Assert.assertEquals()}} should be an {{expected}} value, and the second one should be an {{actual}} value. > {code} > void assertEquals(T expected, T actual); > {code} > http://junit.org/apidocs/org/junit/Assert.html#assertEquals(java.lang.Object, java.lang.Object) > However, there are so many violations in Hadoop, which can make a misleading message like this: > {code} > AssertionError: expected: but was: > {code}. > Please refer to {{just-rough-approx.txt}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)