[ https://issues.apache.org/jira/browse/HADOOP-12693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akihiro Suda updated HADOOP-12693: ---------------------------------- Summary: Many misusages of assertEquals(expected, actual) (was: Many misusage of assertEquals(expected, actual)) > Many misusages of assertEquals(expected, actual) > ------------------------------------------------ > > Key: HADOOP-12693 > URL: https://issues.apache.org/jira/browse/HADOOP-12693 > Project: Hadoop Common > Issue Type: Test > Reporter: Akihiro Suda > Priority: Trivial > Attachments: just-rough-approx.txt > > > The first arg of {{org.JUnit.Assert.assertEquals()}} should be an {{expected}} value, and the second one should be an {{actual}} value. > {code} > void assertEquals(T expected, T actual); > {code} > http://junit.org/apidocs/org/junit/Assert.html#assertEquals(java.lang.Object, java.lang.Object) > However, there are so many violations in Hadoop, which can make a misleading message like this: > {code} > AssertionError: expected: but was: > {code}. > Please refer to {{just-rough-approx.txt}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)