hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gera Shegalov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12803) RunJar should allow overriding the manifest Main-Class via a cli parameter.
Date Fri, 11 Mar 2016 11:04:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190803#comment-15190803
] 

Gera Shegalov commented on HADOOP-12803:
----------------------------------------

SLF4J sounds good.

The reason I did this hack with system properties because otherwise the mock testClientClassLoader
was not working for me, looks like it depends on the order of tests:
{code}
testClientClassLoader(org.apache.hadoop.util.TestRunJar)  Time elapsed: 0.235 sec  <<<
ERROR!
org.mockito.exceptions.misusing.MissingMethodInvocationException: 
when() requires an argument which has to be 'a method call on a mock'.
For example:
    when(mock.getArticles()).thenReturn(articles);

Also, this error might show up because:
1. you stub either of: final/private/equals()/hashCode() methods.
   Those methods *cannot* be stubbed/verified.
2. inside when() you don't call method on mock but on some other object.
	at org.apache.hadoop.util.TestRunJar.testClientClassLoader(TestRunJar.java:150)
{code} 

> RunJar should allow overriding the manifest Main-Class via a cli parameter.
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-12803
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12803
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 2.6.4
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: HADOOP-12803.001.patch, HADOOP-12803.002.patch
>
>
> Currently there is no way to override the main class in the manifest even though main
class can be passed as a parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message