hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12892) fix/rewrite create-release
Date Fri, 18 Mar 2016 23:27:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202358#comment-15202358
] 

Andrew Wang commented on HADOOP-12892:
--------------------------------------

Hi Allen, thanks for working on this. I gave this a try on my machine, and it worked except
for needing to change /usr/bin/bash to /bin/bash in the two scripts. Or should we be using
/usr/bin/env to find bash instead?

Some other misc review comments:

* "yetus_abs" doesn't seem yetus specific, rename to something more generic?
* set_defaults_part1 does some grepping to determine maven variables, can also do that with
the help plugin:

{noformat}
-> % mvn -f hadoop-project/pom.xml help:evaluate -Dexpression=javac.version | grep -v "\["
1.7
-> % mvn help:evaluate -Dexpression=project.version | grep -v "\["
3.0.0-SNAPSHOT
{noformat}

* What does the -Papache-release profile do? I don't see it mentioned in our pom.xml's, and
it at the end it always prints the "don't forget to sign" message. If this is generating signatures,
then it'd be good to adjust the success message to also indicate the paths.
* typo for imgname in dockermode: "createrelase" -> "createrelease"

These comments are all pretty minor though, do you think there is anything important feature-wise
that is still missing? If not, we could check this in after a rev and do the rest as follow-on.

> fix/rewrite create-release
> --------------------------
>
>                 Key: HADOOP-12892
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12892
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-12892.00.patch
>
>
> create-release needs some major surgery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message