hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Burlison (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12926) lz4.c does not detect 64-bit mode properly
Date Tue, 15 Mar 2016 17:19:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195701#comment-15195701
] 

Alan Burlison commented on HADOOP-12926:
----------------------------------------

I've had a quick look, from the LZ4 changelog it looks like r125 redid all the 64-bit detection
code which is where the problem lies. The patch is to a block of code that no longer exists
in r131 so I'm assuming they have probably fixed it anyway. I've submitted the patch to our
internal process today, hopefully I'll have it approved within a day or so and I'll post it
here - it's literally a 1-line change to an existing #if statement to get it to correctly
detect when it is being built 64-bit, there are no changes to the LZ2 code itself.

I'll try and take a look at HADOOP-12572 but I have approximately 60 other test failures that
I suspect are mostly endian-related, so I really don't have much bandwidth to spare to look
at stuff that's cross-platform, which it sounds like the failures in HADOOP-12572 are.

> lz4.c does not detect 64-bit mode properly
> ------------------------------------------
>
>                 Key: HADOOP-12926
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12926
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: native
>    Affects Versions: 2.7.2
>         Environment: All
>            Reporter: Alan Burlison
>            Assignee: Alan Burlison
>
> lz4.c should check to see if the _LP64 macro is defined to correctly detect when it is
being built in 64-bit mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message