hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Masatake Iwasaki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12101) Add automatic search of default Configuration variables to TestConfigurationFieldsBase
Date Thu, 28 Apr 2016 05:38:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261570#comment-15261570
] 

Masatake Iwasaki commented on HADOOP-12101:
-------------------------------------------

verify-xml.sh is intended to be run on top directory of source tree but it is not obvious.
Is it possible to do cd in the script before run_*_xml_test? like
{noformat}
# Main body

cd -P -- "$(dirname -- ${BASH_SOURCE-$0})/.."
dir="$(pwd -P)"
export commonOutputFile="$(find "${dir}" -name org.apache.hadoop.conf.TestCommonConfigurationFields-output.txt)"
...
{noformat}

Otherwise we should add some instruction to comment and usage.


{noformat}
  *)                                                                                     
                                                                                         
           |
    echo "$0 <mode>"
    echo "  where <mode> is one of all, hdfs, mr, yarn"
{noformat}
Usage should be prefixed by "Usage: " and {{common}} is missing in modes.


> Add automatic search of default Configuration variables to TestConfigurationFieldsBase
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12101
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12101
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.7.0
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>              Labels: supportability
>         Attachments: HADOOP-12101.001.patch, HADOOP-12101.002.patch, HADOOP-12101.003.patch,
HADOOP-12101.004.patch, HADOOP-12101.005.patch, HADOOP-12101.006.patch, HADOOP-12101.007.patch,
HADOOP-12101.008.patch, HADOOP-12101.009.patch, HADOOP-12101.010.patch, HADOOP-12101.011.patch,
HADOOP-12101.012.patch
>
>
> Add functionality given a Configuration variable FOO, to at least check the xml file
value against DEFAULT_FOO.
> Without waivers and a mapping for exceptions, this can probably never be a test method
that generates actual errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message