hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13035) AbstractService should set state only after state change
Date Tue, 19 Apr 2016 16:54:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248162#comment-15248162

Wangda Tan commented on HADOOP-13035:

Thanks [~bibinchundatt], could you take a look at failed tests to see if they're real issues
of just a false alarm?

We need to run Maven test for all projects, currently it only runs for Hadoop-common.

I think we need to run Maven tests for all sub-projects down to leaf which depends on the
changes to reduce risks. For example, for changes of Hadoop-common, we should run YARN/HDFS/MR
tests, and for changes of YARN-common, we should run YARN-client/YARN-server tests.

[~aw] could you share your thoughts here? 

> AbstractService should set state only after state change
> --------------------------------------------------------
>                 Key: HADOOP-13035
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13035
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>         Attachments: 0001-HADOOP-13035.patch
> As per the discussion in YARN-3971 the we should be setting the service state to STARTED
only after serviceStart() 
> Currently {{AbstractService#start()}} is set
> {noformat} 
>      if (stateModel.enterState(STATE.STARTED) != STATE.STARTED) {
>         try {
>           startTime = System.currentTimeMillis();
>           serviceStart();
> ..
>  }
> {noformat}
> enterState sets the service state to proposed state. So in {{service.getServiceState}}
in {{serviceStart()}} will return STARTED .

This message was sent by Atlassian JIRA

View raw message