hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13035) AbstractService should set state only after state change
Date Tue, 19 Apr 2016 17:32:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248247#comment-15248247
] 

Allen Wittenauer commented on HADOOP-13035:
-------------------------------------------

Can't happen.

YARN has two modules that take 1 hour each (hadoop-yarn-server-resourcemanager and hadoop-yarn-server-resourcemanager).
 MR has one module that takes two hours (hadoop-mapreduce-client-jobclient).... and that's
for a single JVM.  It simply isn't realistic to run the full gamut of unit tests as part of
precommit. Either someone needs to spend time working on MAPREDUCE-6674 and YARN-4950 and
probably follow-ons to at least cut the times for all these modules in half or someone needs
to double the amount of build resources available at Apache so that we can have longer run
times.


> AbstractService should set state only after state change
> --------------------------------------------------------
>
>                 Key: HADOOP-13035
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13035
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>         Attachments: 0001-HADOOP-13035.patch
>
>
> As per the discussion in YARN-3971 the we should be setting the service state to STARTED
only after serviceStart() 
> Currently {{AbstractService#start()}} is set
> {noformat} 
>      if (stateModel.enterState(STATE.STARTED) != STATE.STARTED) {
>         try {
>           startTime = System.currentTimeMillis();
>           serviceStart();
> ..
>  }
> {noformat}
> enterState sets the service state to proposed state. So in {{service.getServiceState}}
in {{serviceStart()}} will return STARTED .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message