From common-issues-return-107293-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org Mon Apr 18 13:47:26 2016 Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 83E76189D9 for ; Mon, 18 Apr 2016 13:47:26 +0000 (UTC) Received: (qmail 47587 invoked by uid 500); 18 Apr 2016 13:47:26 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 47509 invoked by uid 500); 18 Apr 2016 13:47:25 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 47407 invoked by uid 99); 18 Apr 2016 13:47:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Apr 2016 13:47:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 923852C1F60 for ; Mon, 18 Apr 2016 13:47:25 +0000 (UTC) Date: Mon, 18 Apr 2016 13:47:25 +0000 (UTC) From: "Naganarasimha G R (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-13035) AbstractService should set state only after state change MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245676#comment-15245676 ] Naganarasimha G R commented on HADOOP-13035: -------------------------------------------- Hi [~bibinchundatt], if you have a patch for this, please upload so that we can cross verify how many failures and evaluate the risk with this change. > AbstractService should set state only after state change > -------------------------------------------------------- > > Key: HADOOP-13035 > URL: https://issues.apache.org/jira/browse/HADOOP-13035 > Project: Hadoop Common > Issue Type: Bug > Reporter: Bibin A Chundatt > > As per the discussion in YARN-3971 the we should be setting the service state to STARTED only after serviceStart() > Currently {{AbstractService#start()}} is set > {noformat} > if (stateModel.enterState(STATE.STARTED) != STATE.STARTED) { > try { > startTime = System.currentTimeMillis(); > serviceStart(); > .. > } > {noformat} > enterState sets the service state to proposed state. So in {{service.getServiceState}} in {{serviceStart()}} will return STARTED . -- This message was sent by Atlassian JIRA (v6.3.4#6332)