hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12893) Verify LICENSE.txt and NOTICE.txt
Date Fri, 27 May 2016 00:56:13 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Wang updated HADOOP-12893:
---------------------------------
    Attachment: HADOOP-12893.007.patch

I made a few improvements to Xiao's patch:
* Tweaked the pom dependencies so it works with a clean m2 cache
* Removed "-" from new module name for consistency
* Changed the LICENSE.txt wording to reflect that these new additions are only for the binary
distribution
* Pulled mockito and slf4j to their own copy of the MIT license, since the existing version
for bootstrap has the Twitter copyright

I wrote the following script to make sure all the generated JARs have the LICENSE and NOTICE:

{code}
for f in $(find . -name "hadoop*SNAPSHOT.jar"); do
    jar -tf $f | grep "LICENSE" > /dev/null
    RET1=$?
    jar -tf $f | grep "NOTICE" > /dev/null
    RET2=$?

    if [ $RET1 -ne 0 -a $RET2 -ne 0 ]; then
        echo $f "missing LICENSE and NOTICE!";
    elif [ $RET1 -ne 0 ]; then
        echo $f "missing LICENSE!";
    elif [ $RET2 -ne 0 ]; then
        echo $f "missing NOTICE!";
    fi
done
{code}

This is the output:

{quote}
./hadoop-project-dist/target/hadoop-project-dist-3.0.0-alpha1-SNAPSHOT.jar missing LICENSE
and NOTICE!
./hadoop-project-dist/target/hadoop-project-dist-3.0.0-alpha1-SNAPSHOT/share/hadoop/UNDEF/hadoop-project-dist-3.0.0-alpha1-SNAPSHOT.jar
missing LICENSE and NOTICE!
./hadoop-build-tools/target/hadoop-build-tools-3.0.0-alpha1-SNAPSHOT.jar missing LICENSE and
NOTICE!
{quote}

This is because these inherit from hadoop-main rather than hadoop-project, which is where
the remote-resources-plugin is called. There's not much in these JARs, so we might not need
to generate/deploy them. If we do, then we can do some special-case L&N work.

> Verify LICENSE.txt and NOTICE.txt
> ---------------------------------
>
>                 Key: HADOOP-12893
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12893
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>            Reporter: Allen Wittenauer
>            Assignee: Xiao Chen
>            Priority: Blocker
>         Attachments: HADOOP-12893.002.patch, HADOOP-12893.003.patch, HADOOP-12893.004.patch,
HADOOP-12893.005.patch, HADOOP-12893.006.patch, HADOOP-12893.007.patch, HADOOP-12893.01.patch
>
>
> We have many bundled dependencies in both the source and the binary artifacts that are
not in LICENSE.txt and NOTICE.txt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message