hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13154) S3AFileSystem printAmazonServiceException/printAmazonClientException appear copy & paste of AWS examples
Date Tue, 17 May 2016 09:16:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286272#comment-15286272
] 

Steve Loughran commented on HADOOP-13154:
-----------------------------------------

Oh, it's been along for a while, I was the one who put in the contributed code. I only realised
yesterday that this is the case.

in HADOOP-13130 I pull the methods out, but that is part of a bigger diff.

I think for 2.7 we can/should just add a comment in the credits of the file (and other license
file) saying "from Amazon"

> S3AFileSystem printAmazonServiceException/printAmazonClientException appear copy &
paste of AWS examples
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13154
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13154
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.7.2
>            Reporter: Steve Loughran
>            Priority: Blocker
>
> The logging code in {{S3AFileSystem.printAmazonServiceException()}} and {{printAmazonClientException}}
appear to be paste + edits of the example code in  the amazon SDK, such as [http://docs.aws.amazon.com/AmazonS3/latest/dev/ListingObjectKeysUsingJava.html]]
> Either we review the license to validate it, and add credits to the code if compatible,
or we rework. HADOOP-13130 would be the place to do that, as it is changing exception handling
anyway.
> tagging as blocker as it is license related



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message