hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13341) Deprecate HADOOP_SERVERNAME_OPTS; replace with (command)_(subcommand)_OPTS
Date Sat, 27 Aug 2016 02:43:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440510#comment-15440510
] 

Allen Wittenauer commented on HADOOP-13341:
-------------------------------------------

I'm opting instead to go with:


* HADOOP_OPTS
* HADOOP_CLIENTS_OPTS
* HADOOP_(subcommand)_OPTS

with the thought that subcommand is more specific than CLIENTS.  It's trivial to flip (just
swap two function calls in the commands) if anyone disagrees.

I've also hit an interesting dilemma  in the form of the secure opts in HDFS.  Opening a new
subtask to keep track of that.

> Deprecate HADOOP_SERVERNAME_OPTS; replace with (command)_(subcommand)_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-13341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13341
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>
> Big features like YARN-2928 demonstrate that even senior level Hadoop developers forget
that daemons need a custom _OPTS env var.  We can replace all of the custom vars with generic
handling just like we do for the username check.
> For example, with generic handling in place:
> || Old Var || New Var ||
> | HADOOP_NAMENODE_OPTS | HDFS_namenode_OPTS |
> | YARN_RESOURCEMANAGER_OPTS | YARN_resourcemanager_OPTS |
> | n/a | YARN_timelinereader_OPTS |
> | n/a | HADOOP_distcp_OPTS |
> | n/a | MAPRED_distcp_OPTS |
> This makes it:
> a) consistent across the entire project
> b) consistent for every subcommand
> c) eliminates almost all of the custom appending in the case statements
> It's worth pointing out that subcommands like distcp that sometimes need a higher than
normal client-side heapsize or custom options are a huge win.  Combined with .hadooprc and/or
dynamic subcommands, it means users can easily do customizations based upon their needs without
a lot of weirdo shell aliasing or one line shell scripts off to the side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message