hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13396) Add json format audit logging to KMS
Date Wed, 10 Aug 2016 06:05:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414776#comment-15414776
] 

Xiao Chen commented on HADOOP-13396:
------------------------------------

Thanks [~jojochuang] for the review and comments. Patch 5 addressed all except:

bq. KMSAudit.JsonKMSAuditLogger#logAuditEvent This won’t print the exception nor its stack
trace. The similar kind of change is needed for handling other exceptions.
Not sure what exactly the concern is. Per http://www.slf4j.org/apidocs/org/slf4j/Logger.html,
the throwable works. Also verified locally.

bq. KMSAudit#op: RuntimeException v.s. ExecutionException
Thanks for pointing me offline to http://google.github.io/guava/releases/snapshot/api/docs/com/google/common/cache/LoadingCache.html#getUnchecked(K)
. Here it's calling [get(K, Callable)|http://google.github.io/guava/releases/snapshot/api/docs/com/google/common/cache/Cache.html#get(K,%20java.util.concurrent.Callable)]
though, I didn't find a replacement. It's out of this jira's scope too, so let's follow up
in new jira.

> Add json format audit logging to KMS
> ------------------------------------
>
>                 Key: HADOOP-13396
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13396
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: kms
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-13396.01.patch, HADOOP-13396.02.patch, HADOOP-13396.03.patch,
HADOOP-13396.04.patch, HADOOP-13396.05.patch
>
>
> Currently, KMS audit log is using log4j, to write a text format log.
> We should refactor this, so that people can easily add new format audit logs. The current
text format log should be the default, and all of its behavior should remain compatible.
> A json format log extension is added using the refactored API, and being turned off by
default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message