hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-13559) Remove close() within try-with-resources
Date Mon, 29 Aug 2016 17:06:20 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Aaron Fabbri updated HADOOP-13559:
----------------------------------
    Attachment: HADOOP-13559-001.patch

Attaching v1 patch.  Hat tip to [~mackrorysd] for catching this.

> Remove close() within try-with-resources
> ----------------------------------------
>
>                 Key: HADOOP-13559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13559
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.8.0, 2.9.0
>            Reporter: Aaron Fabbri
>            Assignee: Aaron Fabbri
>            Priority: Minor
>         Attachments: HADOOP-13559-001.patch
>
>
> My colleague noticed that HADOOP-12994 introduced to places where close() was still called
manually within a try-with-resources block.
> I'll attach a patch to remove the manual close() calls. 
> These extra calls to close() are probably safe, as InputStream is a Closable, not AutoClosable
(the later does not specify close() as idempotent).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message