hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13985) s3guard: add a version marker to every table
Date Wed, 25 Jan 2017 20:00:31 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838473#comment-15838473

Aaron Fabbri commented on HADOOP-13985:

Thanks for doing this.  I agree this is a must-have.  Looks good overall, so +1.  Comments

@@ -132,6 +133,13 @@ public boolean isValidName(String src) {
         CONSTRUCTOR_CACHE.put(theClass, meth);
       result = meth.newInstance(uri, conf);
+    } catch (InvocationTargetException e) {
+      Throwable cause = e.getCause();
+      if (cause instanceof RuntimeException) {

If you end up rolling another patch, should we add a comment here, e.g. "// preserve exception
cause text"?

Overall, looks good to me.  I love the Java 8 stuff, but it is going to cause me a little
pain backporting.

I'm baffled on getItem() creating a table.  The SDK docs don't seem to mention that behavior.

> s3guard: add a version marker to every table
> --------------------------------------------
>                 Key: HADOOP-13985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13985
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: HADOOP-13985-HADOOP-13345-001.patch, HADOOP-13985-HADOOP-13345-002.patch
> This is something else we need before any preview: a way to identify a table version,
so that if future versions change the table structure:
> * older clients can recognise that it's a newer format, and fail
> * the future version can identify that it's an older format, and fail until some fsck-upgrade
operation has taken place
> I think something like a row on a path which is impossible in a real filesystem, such
as "../VERSION" would allow a version marker to go in; the length field could be abused for
the version number.
> This field would be something that'd be checked in init(), so be the simple test for
table existence we need for faster init

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message