From common-issues-return-124704-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org Thu Jan 5 19:40:59 2017 Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 238EC1942D for ; Thu, 5 Jan 2017 19:40:59 +0000 (UTC) Received: (qmail 67229 invoked by uid 500); 5 Jan 2017 19:40:58 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 67174 invoked by uid 500); 5 Jan 2017 19:40:58 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 67157 invoked by uid 99); 5 Jan 2017 19:40:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jan 2017 19:40:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 88A9E2C2A6E for ; Thu, 5 Jan 2017 19:40:58 +0000 (UTC) Date: Thu, 5 Jan 2017 19:40:58 +0000 (UTC) From: "Junping Du (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-13438) Optimize IPC server protobuf decoding MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802314#comment-15802314 ] Junping Du commented on HADOOP-13438: ------------------------------------- Thanks Andrew for share. My practice to make sure all JIRAs with fixVersion 2.8 get landed in branch-2.8 already get done, please check https://cwiki.apache.org/confluence/display/HADOOP/Hadoop+2.8+Release for details. Actually, we were facing 4 situations here when identify no commits landing JIRA: 1. commit message typo 2. claim commit to branch-2 but mark 2.8.0 as fixed version 3. claim to commit to branch-2.8 but forget to push to branch-2.8 for some reason 4. duplicated JIRA or umbrella JIRA Even one jira is identified as situation 1, we have to manually check if it belongs to situation 2 and 3. Thus, only list all typos JIRA here may have limited help for 2.8 release, but thanks all the same. > Optimize IPC server protobuf decoding > ------------------------------------- > > Key: HADOOP-13438 > URL: https://issues.apache.org/jira/browse/HADOOP-13438 > Project: Hadoop Common > Issue Type: Sub-task > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Fix For: 2.8.0, 3.0.0-alpha1 > > Attachments: HADOOP-13438.patch, HADOOP-13438.patch.1 > > > The current use of the protobuf API uses an expensive code path. The builder uses the parser to instantiate a message, then copies the message into the builder. The parser is creating multi-layered internally buffering streams that cause excessive byte[] allocations. > Using the parser directly with a coded input stream backed by the byte[] from the wire will take a fast-path straight to the pb message's ctor. Substantially less garbage is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org