hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14129) ITestS3ACredentialsInURL sometimes fails
Date Thu, 02 Mar 2017 22:41:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893177#comment-15893177
] 

Aaron Fabbri commented on HADOOP-14129:
---------------------------------------

+1 on v4 patch.  One minor question:

{code}
@@ -85,8 +91,6 @@ public void testInstantiateFromURL() throws Throwable {
     conf.unset(Constants.SECRET_KEY);
     fs = S3ATestUtils.createTestFileSystem(conf);
  
-    // Skip in the case of S3Guard with DynamoDB because it cannot get
-    // credentials for its own use if they're only in S3 URLs
     Assume.assumeFalse(fs.hasMetadataStore());
  
     String fsURI = fs.getUri().toString();
{code}
Do we still need this assumeFalse() too? 


> ITestS3ACredentialsInURL sometimes fails
> ----------------------------------------
>
>                 Key: HADOOP-14129
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14129
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: HADOOP-13345
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>             Fix For: HADOOP-13345
>
>         Attachments: HADOOP-14129-HADOOP-13345.001.patch, HADOOP-14129-HADOOP-13345.002.patch,
HADOOP-14129-HADOOP-13345.003.patch, HADOOP-14129-HADOOP-13345.004.patch
>
>
> This test sometimes fails. I believe it's expected that DynamoDB doesn't have access
to the credentials if they're embedded in the URL instead of the configuration (and IMO that's
fine - since the functionality hasn't been in previous releases and since we want to discourage
this practice especially now that there are better alternatives). Weirdly, I only sometimes
get this failure on the HADOOP-13345 branch. But if the problem turns out to be what I think
it is, a simple Assume should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message