hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andras Bokor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11869) checkstyle rules/script need re-visiting
Date Mon, 15 May 2017 14:11:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010584#comment-16010584

Andras Bokor commented on HADOOP-11869:

bq. Line is longer than 80 characters
Fixed by HADOOP-13603.

bq. "Missing a Javadoc comment." - for every private member including cases like "Configuration
Currently only {{JavadocType}} is turned on. So checkstyle checks Javadoc comments for class
and interface definitions only.

> checkstyle rules/script need re-visiting
> ----------------------------------------
>                 Key: HADOOP-11869
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11869
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Sidharta Seethana
>         Attachments: HADOOP-11869.ParameterNumber.patch
> There seem to be a lot of arcane errors being caused by the checkstyle rules/script.
Real issues tend to be buried in this noise. Some examples :
> 1. "Line is longer than 80 characters" - this shows up even for cases like import statements,
package names
> 2. "Missing a Javadoc comment." - for every private member including cases like "Configuration
> Having rules like these will result in a large number of pre-commit job failures. We
should fine tune the rules used for checkstyle. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message