hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Mackrory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13760) S3Guard: add delete tracking
Date Wed, 31 May 2017 16:28:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031458#comment-16031458

Sean Mackrory commented on HADOOP-13760:

{quote}Why not make use of switch() statements in the S3A FS in innerMkdirs{quote}

The original patch did, actually - it's cleaner to read IMO. There was some fall-through logic
which findbugs didn't like. I had added an exception, but one could just duplicate the parts
that fall through instead. Fabbri preferred if statements for this in the review and I don't
feel particularly strongly about it. Fabbri is also of the opinion that this logic could be
simplified further (see his comments in HADOOP-14457), so I'll likely be revisiting this chunk
altogether and the logic may be a bit simpler again - and maybe switch vs. if can be revisited
as part of those changes.

{quote}delete() javadocs provide more detail on what's happening.{quote}

I'm afraid I don't follow what you're saying in #2 and the subsequent paragraph. Sounds like
you're saying delete() javadocs should NOT say more detail, but I didn't change that functions
javadocs at all.

{quote}The error message raised if a parent element is a file has changed and no longer correct{quote}

Noted - I'll get that fixed.

> S3Guard: add delete tracking
> ----------------------------
>                 Key: HADOOP-13760
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13760
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Aaron Fabbri
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-13760-HADOOP-13345.001.patch, HADOOP-13760-HADOOP-13345.002.patch,
HADOOP-13760-HADOOP-13345.003.patch, HADOOP-13760-HADOOP-13345.004.patch, HADOOP-13760-HADOOP-13345.005.patch,
HADOOP-13760-HADOOP-13345.006.patch, HADOOP-13760-HADOOP-13345.007.patch, HADOOP-13760-HADOOP-13345.008.patch,
HADOOP-13760-HADOOP-13345.009.patch, HADOOP-13760-HADOOP-13345.010.patch, HADOOP-13760-HADOOP-13345.011.patch,
HADOOP-13760-HADOOP-13345.012.patch, HADOOP-13760-HADOOP-13345.013.patch
> Following the S3AFileSystem integration patch in HADOOP-13651, we need to add delete
> Current behavior on delete is to remove the metadata from the MetadataStore.  To make
deletes consistent, we need to add a {{isDeleted}} flag to {{PathMetadata}} and check it when
returning results from functions like {{getFileStatus()}} and {{listStatus()}}.  In HADOOP-13651,
I added TODO comments in most of the places these new conditions are needed.  The work does
not look too bad.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message