hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Inigo Goiri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14369) NetworkTopology calls expensive toString() when debugging
Date Mon, 01 May 2017 23:34:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991788#comment-15991788

Inigo Goiri commented on HADOOP-14369:

[~xiaochen], this was introduced in HDFS-10320 when switching to {{Logger}}.
I think this is the right way to avoid building the whole String.
I think we should also fix:
LOG.debug("Failed to find datanode (scope=\"{}\" excludedScope=\"{}\").",
    String.valueOf(scope), String.valueOf(excludedScope));
Not sure of the reason for {{valueOf()}}.

> NetworkTopology calls expensive toString() when debugging
> ---------------------------------------------------------
>                 Key: HADOOP-14369
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14369
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Inigo Goiri
>            Assignee: Inigo Goiri
>         Attachments: HADOOP-14369-000.patch
> When {{NetworkTopology}} calls {{add()}} or {{remove()}}, it calls {{toString()}} for
{{LOG.debug()}} which is pretty expensive.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message