hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14914) Change to a safely casting long to int.
Date Wed, 25 Oct 2017 21:52:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219606#comment-16219606

Arpit Agarwal commented on HADOOP-14914:

Some of these casts may be deliberate, so I don't think we should replace all occurrences
without trying to understand the intent behind each of them.

> Change to a safely casting long to int. 
> ----------------------------------------
>                 Key: HADOOP-14914
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14914
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Yufei Gu
>            Assignee: Ajay Kumar
>         Attachments: HADOOP-14914.001.patch
> There are bunches of casting long to int like this:
> {code}
> long l = 123
> int i = (int) l;
> {code}
> This is not a safe cast. if l is greater than Integer.MAX_VALUE, i would be negative,
which is an unexpected behavior. We probably at least want to throw an exception in that case.
I suggest to use {{Math.toIntExact(longValue)}} to replace them, which throws an exception
if the value overflows an int. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message