From common-issues-return-142178-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org Tue Oct 3 00:26:08 2017 Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4728910AAA for ; Tue, 3 Oct 2017 00:26:08 +0000 (UTC) Received: (qmail 17271 invoked by uid 500); 3 Oct 2017 00:26:08 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 17223 invoked by uid 500); 3 Oct 2017 00:26:08 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 17212 invoked by uid 99); 3 Oct 2017 00:26:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Oct 2017 00:26:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D64901A5A32 for ; Tue, 3 Oct 2017 00:26:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id wrLa1eAKk67m for ; Tue, 3 Oct 2017 00:26:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 752FB5F6D3 for ; Tue, 3 Oct 2017 00:26:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9267FE0F7B for ; Tue, 3 Oct 2017 00:26:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 31327242DF for ; Tue, 3 Oct 2017 00:26:01 +0000 (UTC) Date: Tue, 3 Oct 2017 00:26:01 +0000 (UTC) From: "Masatake Iwasaki (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-12672) RPC timeout should not override IPC ping interval MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189105#comment-16189105 ] Masatake Iwasaki commented on HADOOP-12672: ------------------------------------------- [~yufeigu] I think using 0 as no timeout is natural because the rpc timeout results in java.net.Socket#setSoTimeout which interpret 0 as an infinite timeout. The many part of the code seems to use the timeout value 0 as infinite timeout. While Client#getTimeout returns -1 implying that ipc.client.ping is disabled, it is remains of the past code in which rpc timeout is tightly coupled with ipc ping. I agree to improve documentation to make it clear that the rpc timeout is disabled by default (for compatibility reason). > RPC timeout should not override IPC ping interval > ------------------------------------------------- > > Key: HADOOP-12672 > URL: https://issues.apache.org/jira/browse/HADOOP-12672 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc > Affects Versions: 2.8.0, 2.7.3, 2.6.4 > Reporter: Masatake Iwasaki > Assignee: Masatake Iwasaki > Fix For: 2.8.0, 3.0.0-alpha1 > > Attachments: HADOOP-12672.001.patch, HADOOP-12672.002.patch, HADOOP-12672.003.patch, HADOOP-12672.004.patch, HADOOP-12672.005.patch, HADOOP-12672.006.patch > > > Currently if the value of ipc.client.rpc-timeout.ms is greater than 0, the timeout overrides the ipc.ping.interval and client will throw exception instead of sending ping when the interval is passed. RPC timeout should work without effectively disabling IPC ping. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org