From common-issues-return-142192-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org Tue Oct 3 06:37:15 2017 Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA1391028C for ; Tue, 3 Oct 2017 06:37:15 +0000 (UTC) Received: (qmail 97213 invoked by uid 500); 3 Oct 2017 06:37:10 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 97164 invoked by uid 500); 3 Oct 2017 06:37:10 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 97153 invoked by uid 99); 3 Oct 2017 06:37:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Oct 2017 06:37:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4B71DDB1AF for ; Tue, 3 Oct 2017 06:37:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id yAfkPtqoCwo2 for ; Tue, 3 Oct 2017 06:37:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3119B5FB40 for ; Tue, 3 Oct 2017 06:37:08 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 49861E0FA2 for ; Tue, 3 Oct 2017 06:37:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CE1AF242DF for ; Tue, 3 Oct 2017 06:37:02 +0000 (UTC) Date: Tue, 3 Oct 2017 06:37:02 +0000 (UTC) From: "Yufei Gu (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-12672) RPC timeout should not override IPC ping interval MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189326#comment-16189326 ] Yufei Gu commented on HADOOP-12672: ----------------------------------- Thanks [~iwasakims]. I think that *zero means infinity* is counter-intuitive and error-prone through Java lib does that as well. Zero could be considered as a valid timeout value, while negative one isn't. It's kinda of like the debut of if zero is the natural number. If we use zero to represent infinity, which number could be used to represent no timeout? Both Client#getTimeout and Client#geRpcTimeout are not used really, only a unit test calls that. They probably are fine to change. > RPC timeout should not override IPC ping interval > ------------------------------------------------- > > Key: HADOOP-12672 > URL: https://issues.apache.org/jira/browse/HADOOP-12672 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc > Affects Versions: 2.8.0, 2.7.3, 2.6.4 > Reporter: Masatake Iwasaki > Assignee: Masatake Iwasaki > Fix For: 2.8.0, 3.0.0-alpha1 > > Attachments: HADOOP-12672.001.patch, HADOOP-12672.002.patch, HADOOP-12672.003.patch, HADOOP-12672.004.patch, HADOOP-12672.005.patch, HADOOP-12672.006.patch > > > Currently if the value of ipc.client.rpc-timeout.ms is greater than 0, the timeout overrides the ipc.ping.interval and client will throw exception instead of sending ping when the interval is passed. RPC timeout should work without effectively disabling IPC ping. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org