hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10571) Use Log.*(Object, Throwable) overload to log exceptions
Date Mon, 05 Feb 2018 18:21:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352722#comment-16352722
] 

Steve Loughran commented on HADOOP-10571:
-----------------------------------------

It's way past time to get this in, so lets aim for this week. I've reviewed it all by counting
{} and arg numbers,  checking that e.getMessage() is only called when I'm happy that this
value isn't null (i.e. if its a subclass of IOE),
and that no info is being lost compared to before.

As this goes near HDFS, can you create a JIRA here and mark it as part of this one? That'll
let the hdfs dev team know what's coming.

h4. LocalFileSystem

L142 we could move to making {{p}} another arg

h4. DNS


L314. The log pattern doesn't include the localhost string

L432: review

h4. DataNode

L2435 that's complex enough that it should retain the debug enabled guard. 
L2435 replace use of %d with {}

L2724. Use e.toString()

L3360. Possibly better as {{LOG.debug("{}", sb)}} ; avoids calling sb.toString() when not
needed

h4. DataXceiver

L717 retain isDebug guard to avoid calling Arrays.asList()

h3. EditLogBackupInputStream

revert. Ensures text of underlying error isn't lost on rethrow

h4.  StandbyCheckpointer


> Use Log.*(Object, Throwable) overload to log exceptions
> -------------------------------------------------------
>
>                 Key: HADOOP-10571
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10571
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Arpit Agarwal
>            Assignee: Andras Bokor
>            Priority: Major
>         Attachments: HADOOP-10571.01.patch, HADOOP-10571.01.patch, HADOOP-10571.02.patch,
HADOOP-10571.03.patch, HADOOP-10571.04.patch
>
>
> When logging an exception, we often convert the exception to string or call {{.getMessage}}.
Instead we can use the log method overloads which take {{Throwable}} as a parameter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message