hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elek, Marton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15007) Stabilize and document Configuration <tag> element
Date Sun, 11 Feb 2018 10:05:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359873#comment-16359873

Elek, Marton commented on HADOOP-15007:

Thanks [~ajayydv] the patch.

But (to be honest) this is not exactly what I proposed. From my previous comment:
{quote}My preference is:
 # Don't use tags in the code at all (only return existing tags as a List<String> to
the ui)
 # Use enums to represent tags
 # Use string constants to represent tags

I agree with Anu that 2 is better then 3 and I agree we Steve that 1 is better then 2.
It could my fault as my proposal was not clean enough, but the current patch implements the
3rd option. I agreed with [~anu] that enum is better than string constant.

My proposal was to remove the PropertyTag class at all as none of the fields are used. The
only used code from PropertyTag is the contains method. But as the _contains_ method is used
to log something on the *trace* level (I am pretty sure that it almost never never be logged
in the universe) I proposed to remove the PropertyTag class and the check and Configuration.java:3113
(That is 1st option on my list).

To avoid typo I proposed to extend TestConfigurationFieldsBase (in different jira) to do a
similar check based on the existing used tags (eg. every tag should be associated at least
4 config keys)

I don't say this is the best approach, but it was my original proposal.

> Stabilize and document Configuration <tag> element
> --------------------------------------------------
>                 Key: HADOOP-15007
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15007
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.1.0
>            Reporter: Steve Loughran
>            Assignee: Ajay Kumar
>            Priority: Blocker
>         Attachments: HADOOP-15007.000.patch
> HDFS-12350 (moved to HADOOP-15005). Adds the ability to tag properties with a <tag>
> We need to make sure that this feature is backwards compatible & usable in production.
That's docs, testing, marshalling etc.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message