hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elek, Marton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15007) Stabilize and document Configuration <tag> element
Date Thu, 01 Feb 2018 11:19:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348427#comment-16348427
] 

Elek, Marton commented on HADOOP-15007:
---------------------------------------

[~anu] I understand your concerns about type-safety. My only note is that there is a big difference
between tags and configuration keys. Configuration keys (such as OzoneConfigurationKeys.OZONE_CLIENT_SOCKET_TIMEOUT_DEFAULT)
are used in the code, but the element of the tags are never used anywhere. 

That's the reason that I think we don't need the enum, as the elements of the enums are not
used at all. We need just a list of the used values. (And I also dont't expect any other usage
in the future).

With other words: If nobody cares about the warnings (we would like to move them to the debug
level), why do we need warnings?
{quote}I see your point but how we will register a class which is not in classpath of common?
Another option is to create a common class for property tags and use it for everything. i.e
hdfs,yarn etc.
{quote}
As an alternative approach it could be done with Service Provider Interface (java.util.ServiceLoader).
With this approach the required enums could be provided by the other jars from the classpath.

 

 

> Stabilize and document Configuration <tag> element
> --------------------------------------------------
>
>                 Key: HADOOP-15007
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15007
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.1.0
>            Reporter: Steve Loughran
>            Assignee: Ajay Kumar
>            Priority: Blocker
>
> HDFS-12350 (moved to HADOOP-15005). Adds the ability to tag properties with a <tag>
value.
> We need to make sure that this feature is backwards compatible & usable in production.
That's docs, testing, marshalling etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message