hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Brennan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15357) Configuration.getPropsWithPrefix no longer does variable substitution
Date Mon, 02 Apr 2018 19:14:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423004#comment-16423004
] 

Jim Brennan commented on HADOOP-15357:
--------------------------------------

I think you can just replace this:
{code:java}
        String value = props.getProperty(name);
{code}
with this:
{code:java}
        String value = get(name);
{code}
I'm not certain if we need to worry about the deprecation stuff in Configuration.get() for
this. If it's not needed, then I think this would be all we'd need:
{code:java}
        String value = substituteVars(props.getProperty(name));
{code}

> Configuration.getPropsWithPrefix no longer does variable substitution
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-15357
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15357
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Jim Brennan
>            Priority: Major
>
> Before [HADOOP-13556], Configuration.getPropsWithPrefix() used the Configuration.get()
method to get the value of the variables.   After [HADOOP-13556], it now uses props.getProperty().
> The difference is that Configuration.get() does deprecation handling and more importantly
variable substitution on the value.  So if a property has a variable specified with ${variable_name},
it will no longer be expanded when retrieved via getPropsWithPrefix().
> Was this change in behavior intentional?  I am using this function in the fix for [MAPREDUCE-7069],
but we do want variable expansion to happen.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message