hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-15442) ITestS3AMetrics.testMetricsRegister can't know metrics source's name
Date Tue, 15 May 2018 15:17:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Steve Loughran updated HADOOP-15442:
------------------------------------
       Resolution: Fixed
    Fix Version/s: 3.1.1
           Status: Resolved  (was: Patch Available)

committed to branch-3.1 & trunk/ Thx for fixing this..flaky tests are always a pain, but
hard to motivate yourself to fix unless you are rigorous...

> ITestS3AMetrics.testMetricsRegister can't know metrics source's name
> --------------------------------------------------------------------
>
>                 Key: HADOOP-15442
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15442
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3, metrics
>    Affects Versions: 3.1.0
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Major
>             Fix For: 3.1.1
>
>         Attachments: HADOOP-15442.001.patch
>
>
> I've seen this test fail a bunch lately - mainly when the tests are all run (i.e. not
individually) but not in parallel, it seems. If you dump out the sources when it fails, you
see:
> * The sources are numbered in the hundreds, so it's very unlikely that this actually
gets the first one.
> * The sources are numbered twice. There was logic to have the first one not be numbered,
but that got messed up and now all sources are numbered twice, but the first one is only number
once.
> We could just remove the bad assertion, but then we're only testing the registry and
not anything else about the way metrics flow all the way through the whole system. Worth it
to fix the failing test, I think - knowing the source gets registered doesn't add a whole
lot of value toward end-to-end metrics testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message