hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shane Mainali (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15546) ABFS: tune imports & javadocs; stabilise tests
Date Sun, 22 Jul 2018 20:55:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552151#comment-16552151

Shane Mainali commented on HADOOP-15546:

[~DanielZhou], can you help take a look to see if there's something wrong with the configuration?
[~tmarquardt] was looking optimistically during his OOF but we should look further. From discussion
with [~tmarquardt], there are a few things to address probably but it shouldn't be a major

> ABFS: tune imports & javadocs; stabilise tests
> ----------------------------------------------
>                 Key: HADOOP-15546
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15546
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: HADOOP-15407
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>         Attachments: HADOOP-15546-001.patch, HADOOP-15546-HADOOP-15407-001.patch, HADOOP-15546-HADOOP-15407-002.patch,
HADOOP-15546-HADOOP-15407-003.patch, HADOOP-15546-HADOOP-15407-004.patch, HADOOP-15546-HADOOP-15407-005.patch,
HADOOP-15546-HADOOP-15407-006.patch, HADOOP-15546-HADOOP-15407-006.patch, HADOOP-15546-HADOOP-15407-007.patch,
HADOOP-15546-HADOOP-15407-008.patch, azure-auth-keys.xml
> Followup on HADOOP-15540 with some initial review tuning
> h2. Tuning
> * ordering of imports
> * rely on azure-auth-keys.xml to store credentials (change imports, docs,.gitignore)
> * log4j -> info
> * add a "." to the first sentence of all the javadocs I noticed.
> * remove @Public annotations except for some constants (which includes some commitment
to maintain them).
> * move the AbstractFS declarations out of the src/test/resources XML file into core-default.xml
for all to use
> * other IDE-suggested tweaks
> h2. Testing
> Review the tests, move to ContractTestUtil assertions, make more consistent to contract
test setup, and general work to make the tests work well over slower links, document, etc.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message