hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14556) S3A to support Delegation Tokens
Date Tue, 20 Nov 2018 19:49:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693721#comment-16693721
] 

Íñigo Goiri commented on HADOOP-14556:
--------------------------------------

Thanks [~stevel@apache.org] for  [^HADOOP-14556-021.patch].
* I think we can solve most of the checkstyle issues left here )specially left spaces).
* {{to directly authenticate with S3 and DynamoDB services..}}, you have a double dot here.
* The indices in core-default.xml are dupe, I'm not sure if there's a point on having a number;
anyway, if we keep it we should change the numbers.
* The {{assertEquals}} message in {{AbstractContractGetFileStatusTest}} should have a space
or something in between.
* {{AWSCredentialProviderList}} now does LOG and throw, I think we should keep it as just
throw.
* Constants#DEFAULT_ASSUMED_ROLE_STS_ENDPOINT should fit in one line.
* S3AUtils#getCanonicalServiceURI has comments left behind.
* IAMInstanceCredentialsProvider#getCredentials leaves comments behind.
* In MarshalledCredentialProvider#NAME can use the class.getName() or one of the variations?
* MarshalledCredentials#equals can use EqualsBuilder (same for EncryptionSecrets).
* We use the {{Collections.unmodifiableList(Arrays.asList(}} a lot, it might be worth adding
a method to define constant lists.

In general I can provide a very high level review but somebody else should review deeper.
In any case, general comments:
* The documentation seems to cover the added cases well; it might be worth doing a full pass
to these documents once everything is finished up.
* The unit tests cover the basic cases well.
* Very long patch and even though there are a bunch of interfaces which are pretty verbose,
there is a lot here. I'm not sure if there are ways to split it. For example the utilities
to fetch the DT.

> S3A to support Delegation Tokens
> --------------------------------
>
>                 Key: HADOOP-14556
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14556
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.2.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>         Attachments: HADOOP-14556-001.patch, HADOOP-14556-002.patch, HADOOP-14556-003.patch,
HADOOP-14556-004.patch, HADOOP-14556-005.patch, HADOOP-14556-007.patch, HADOOP-14556-008.patch,
HADOOP-14556-009.patch, HADOOP-14556-010.patch, HADOOP-14556-010.patch, HADOOP-14556-011.patch,
HADOOP-14556-012.patch, HADOOP-14556-013.patch, HADOOP-14556-014.patch, HADOOP-14556-015.patch,
HADOOP-14556-016.patch, HADOOP-14556-017.patch, HADOOP-14556-018a.patch, HADOOP-14556-019.patch,
HADOOP-14556-020.patch, HADOOP-14556-021.patch, HADOOP-14556.oath-002.patch, HADOOP-14556.oath.patch
>
>
> S3A to support delegation tokens where
> * an authenticated client can request a token via {{FileSystem.getDelegationToken()}}
> * Amazon's token service is used to request short-lived session secret & id; these
will be saved in the token and  marshalled with jobs
> * A new authentication provider will look for a token for the current user and authenticate
the user if found
> This will not support renewals; the lifespan of a token will be limited to the initial
duration. Also, as you can't request an STS token from a temporary session, IAM instances
won't be able to issue tokens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message