hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15967) KMS Benchmark Tool
Date Fri, 15 Feb 2019 13:52:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769329#comment-16769329
] 

Wei-Chiu Chuang commented on HADOOP-15967:
------------------------------------------

Thanks for making the patch! [~ghuangups]

Overall looks good. I've also ran the benchmark and it works well.

Some nits I found in the code:

 
{code:java}
* For usage, please see <a href="http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Benchmarking.html#KMSBenchmark">the
documentation</a>.
{code}
There is no doc yet. We should file another Jira to add the doc.

 

 
{code:java}
    LOG.warn("encryption key already exists: ",
	encryptionKeyName);
{code}
Missed a {}
{code:java}
    LOG.warn("encryption key already exists: {}",
	encryptionKeyName);
{code}
{code:java}
    final String HADOOP_SECURITY_KEY_PROVIDER_PATH =
	"hadoop.security.key.provider.path";
{code}
Could you use  {{CommonConfigurationKeysPublic.HADOOP_SECURITY_KEY_PROVIDER_PATH}} instead?
  
{code:java}
    if (keyProvider == null) {
	return null;
    }
{code}
I think we want to throw an exception saying key provider is not configured. Otherwise a null
keyProvider will result in an NPE when accessed later, and that would be hard to troubleshoot.

> KMS Benchmark Tool
> ------------------
>
>                 Key: HADOOP-15967
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15967
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Wei-Chiu Chuang
>            Assignee: George Huang
>            Priority: Major
>         Attachments: HADOOP-15967.001.patch
>
>
> We've been working on several pieces of KMS improvement work. One thing that's missing
so far is a good benchmark tool for KMS, similar to NNThroughputBenchmark.
> Some requirements I have in mind:
> # it should be a standalone benchmark tool, requiring only KMS and a benchmark client.
No NameNode or DataNode should be involved.
> # specify the type of KMS request sent by client. E.g., generate_eek, decrypt_eek, reencrypt_eek
> # optionally specify number of threads sending KMS requests.
> File this jira to gather more requirements. Thoughts? [~knanasi] [~xyao] [~daryn]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message