hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15979) Add Netty support to the RPC client
Date Fri, 15 Feb 2019 20:01:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769667#comment-16769667
] 

Wei-Chiu Chuang commented on HADOOP-15979:
------------------------------------------

Regarding NettyIpcStreams:
 * It may be easier to debug if {{getInputStream()}} returns a named class, rather than an
anonymous class. Similarly for {{getOutputStream()}}.

 
{code:java}
IOException timeout(String op) {
  return new SocketTimeoutException(
      soTimeout + " millis timeout while " +
      "waiting for channel to be ready for " +
      op + ". ch : " + channel);
}
{code}
 * For troubleshooting, it would be helpful when client has a socket time out, throw a SocketTimeoutException
that also record the peer address. Not sure if NioSocketChannel.toString() does that. Maybe
we can add peer address in toException() too.
 * Is channelInactive() still needed?
 * Should there be a interrupt test for NettyIpcStreams, similar to {{TestIPC#testInterrupted}}?

> Add Netty support to the RPC client
> -----------------------------------
>
>                 Key: HADOOP-15979
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15979
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Major
>         Attachments: HADOOP-15979.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much better performance
than that offered by Java's SSLEngine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message