hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] elek commented on a change in pull request #561: HDDS-1043. Enable token based authentication for S3 api.
Date Wed, 06 Mar 2019 14:49:20 GMT
elek commented on a change in pull request #561: HDDS-1043. Enable token based authentication
for S3 api.
URL: https://github.com/apache/hadoop/pull/561#discussion_r262832760
 
 

 ##########
 File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
 ##########
 @@ -567,16 +568,24 @@ message DeleteKeyResponse {
 }
 
 message OMTokenProto {
-    optional uint32 version        = 1;
-    optional string owner          = 2;
-    optional string renewer        = 3;
-    optional string realUser       = 4;
-    optional uint64 issueDate      = 5;
-    optional uint64 maxDate        = 6;
-    optional uint32 sequenceNumber = 7;
-    optional uint32 masterKeyId    = 8;
-    optional uint64 expiryDate     = 9;
-    required string omCertSerialId = 10;
+    enum Type {
 
 Review comment:
   NIT: can we use the same naming convention for both? (eg. upper case + _, or anything else,
just use the same format)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message