hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] ajayydv commented on a change in pull request #561: HDDS-1043. Enable token based authentication for S3 api.
Date Wed, 06 Mar 2019 18:50:42 GMT
ajayydv commented on a change in pull request #561: HDDS-1043. Enable token based authentication
for S3 api.
URL: https://github.com/apache/hadoop/pull/561#discussion_r263083045
 
 

 ##########
 File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/S3SecretManager.java
 ##########
 @@ -27,4 +27,10 @@
 public interface S3SecretManager {
 
   S3SecretValue getS3Secret(String kerberosID) throws IOException;
+
 
 Review comment:
   Renamed new api to getS3UserSecretString, open to any better name you may suggest. Purpose
of both api's is different so consolidating them right not might not be a good option. We
can discuss this further in separate jira.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message