hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] steveloughran commented on issue #539: HADOOP-16109. Parquet reading S3AFileSystem causes EOF
Date Wed, 06 Mar 2019 20:40:38 GMT
steveloughran commented on issue #539: HADOOP-16109. Parquet reading S3AFileSystem causes EOF
URL: https://github.com/apache/hadoop/pull/539#issuecomment-470267763
 
 
   new patch: address core comments from @mattf-apache , including adding a new test case.
   
   Matt, if you ever look at `readByte()`, it is just calling read and checking the return
value before casting
   
   ```java
       public final byte readByte() throws IOException {
           int ch = in.read();
           if (ch < 0)
               throw new EOFException();
           return (byte)(ch);
       }
   ```
   
   the first test was effectively doing it. But in case something in future did ever subclass
it, I've added the new test case

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message