hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] bharatviswa504 commented on a change in pull request #651: HDDS-1339. Implement ratis snapshots on OM
Date Thu, 28 Mar 2019 17:48:44 GMT
bharatviswa504 commented on a change in pull request #651: HDDS-1339. Implement ratis snapshots
on OM
URL: https://github.com/apache/hadoop/pull/651#discussion_r270117510
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java
 ##########
 @@ -186,7 +189,7 @@ public static OzoneManagerRatisServer newOMRatisServer(
       raftPeers.add(raftPeer);
     }
 
-    return new OzoneManagerRatisServer(ozoneConf, om, omServiceId,
+    return new OzoneManagerRatisServer(ozoneConf, omProtocol, omServiceId,
 
 Review comment:
   I think here it should be om? or we should change the method parameter name to omProtocol.
   Currently code is not getting compiled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message