hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shweta (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-16156) [Clean-up] Remove NULL check before instanceof and fix checkstyle in InnerNodeImpl
Date Tue, 19 Mar 2019 19:09:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796438#comment-16796438
] 

Shweta edited comment on HADOOP-16156 at 3/19/19 7:08 PM:
----------------------------------------------------------

Thaks for the review [~templedf]. 

I realized how the functionality of the for loop in the code works and deleting the line was
incorrect on my part. 
Uploaded patch v003.
Looks like the space before the closing brace for the line {code} if (index !=-1) { {code}
was already present.

Added new line before the closing brace for {code} return children; } {code}


was (Author: shwetayakkali):
Thaks for the review [~templedf]. 

I realized how the functionality of the for loop in the code works and deleting the line was
incorrect on my part. 

Looks like the space before the closing brace for the line {code} if (index !=-1) { {code}
was already present.

Added new line before the closing brace for {code} return children; } {code}

> [Clean-up] Remove NULL check before instanceof and fix checkstyle in InnerNodeImpl
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-16156
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16156
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Shweta
>            Assignee: Shweta
>            Priority: Minor
>         Attachments: HADOOP-16156.001.patch, HADOOP-16156.002.patch, HADOOP-16156.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message