hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] steveloughran commented on a change in pull request #666: HADOOP-16221 add option to fail operation on metadata write failure
Date Wed, 24 Apr 2019 13:06:40 GMT
steveloughran commented on a change in pull request #666: HADOOP-16221 add option to fail operation
on metadata write failure
URL: https://github.com/apache/hadoop/pull/666#discussion_r278114271
 
 

 ##########
 File path: hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
 ##########
 @@ -1522,6 +1522,19 @@
     </description>
 </property>
 
+<property>
+  <name>fs.s3a.metadatastore.fail.on.write.error</name>
 
 Review comment:
   Ben - I think you are right. That "swallow the failures" probably follows on from the strategy
of handling failures in the delete fake directories phase, where we don't want a failure there
to escalate. Here we do as it is a sign that the store has gone inconsistent.
   
   If we mandate that update operations always fail the job, well, at least you get to find
out when something has gone wrong. In which case: no need for an option, no need for extra
complications in testing.
   
   *Is there anyone watching this who disagrees? If so, please justify*

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message