hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] arp7 commented on a change in pull request #769: HDDS-1456. Stop the datanode, when any datanode statemachine state is…
Date Thu, 25 Apr 2019 01:48:38 GMT
arp7 commented on a change in pull request #769: HDDS-1456. Stop the datanode, when any datanode
statemachine state is…
URL: https://github.com/apache/hadoop/pull/769#discussion_r278373345
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/StateContext.java
 ##########
 @@ -73,6 +73,7 @@
   private final Queue<ContainerAction> containerActions;
   private final Queue<PipelineAction> pipelineActions;
   private DatanodeStateMachine.DatanodeStates state;
+  private boolean shutdownStateMachine = false;
 
 Review comment:
   Can we avoid this extra flag? Instead can `getShutdownStateMachine` just check whether
`this.state == DatanodeStateMachine.DatanodeStates.SHUTDOWN`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message