hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] arp7 commented on a change in pull request #769: HDDS-1456. Stop the datanode, when any datanode statemachine state is…
Date Thu, 25 Apr 2019 01:57:20 GMT
arp7 commented on a change in pull request #769: HDDS-1456. Stop the datanode, when any datanode
statemachine state is…
URL: https://github.com/apache/hadoop/pull/769#discussion_r278374738
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
 ##########
 @@ -93,7 +95,9 @@
    *                     enabled
    */
   public DatanodeStateMachine(DatanodeDetails datanodeDetails,
-      Configuration conf, CertificateClient certClient) throws IOException {
+      Configuration conf, CertificateClient certClient,
 
 Review comment:
   It also feels unfortunate that we have to pass this back-reference. StateMachine should
not really know about HddsDataNodeService. Now we have a circular dependency.
   
   Can we instead pass a callback via method reference that should be invoked when termination
is necessary?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message