hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] anuengineer commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations
Date Thu, 25 Apr 2019 19:34:46 GMT
anuengineer commented on a change in pull request #773: HDDS-1469. Generate default configuration
fragments based on annotations
URL: https://github.com/apache/hadoop/pull/773#discussion_r278693655
 
 

 ##########
 File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/conf/OzoneConfiguration.java
 ##########
 @@ -45,12 +48,31 @@
 
   public OzoneConfiguration() {
     OzoneConfiguration.activate();
+    loadDefaults();
   }
 
   public OzoneConfiguration(Configuration conf) {
     super(conf);
     //load the configuration from the classloader of the original conf.
     setClassLoader(conf.getClassLoader());
+    loadDefaults();
+  }
+
+  private void loadDefaults() {
 
 Review comment:
   Can I be a greedy pig and request that we also sort these keys (in another JIRA of course)
before we write out the XML? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message