hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] bharatviswa504 commented on a change in pull request #769: HDDS-1456. Stop the datanode, when any datanode statemachine state is…
Date Thu, 25 Apr 2019 21:22:44 GMT
bharatviswa504 commented on a change in pull request #769: HDDS-1456. Stop the datanode, when
any datanode statemachine state is…
URL: https://github.com/apache/hadoop/pull/769#discussion_r278737257
 
 

 ##########
 File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestVolumeSetDiskChecks.java
 ##########
 @@ -141,6 +143,9 @@ HddsVolumeChecker getVolumeChecker(Configuration configuration)
         return new DummyChecker(configuration, new Timer(), numVolumes);
       }
     };
+
+    assertEquals(volumeSet.getFailedVolumesList().size(), numVolumes);
 
 Review comment:
   This is updated like this due to code reordering. As we are calling checkAllVolumes() when
only volumeMap size is not zero. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message