hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] steveloughran commented on issue #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient
Date Fri, 26 Apr 2019 10:52:38 GMT
steveloughran commented on issue #774: HADOOP-16256: HTTPFileSystem disallows users from configuring
the connectionTimeout and readTimeout of HttpClient
URL: https://github.com/apache/hadoop/pull/774#issuecomment-487016093
 
 
   Code looks good, tests look great.
   
   Key comments
   * Move the constants into their own class `HttpFileSystemConstants`
   * and give them relevant names
   * Then reference these in the tests
   * Then add the default values to core-default.xml with descriptions so that generated documentation
lists them. We want people to use them, after all
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message