hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] steveloughran commented on a change in pull request #784: HADOOP-16050: s3a SSL connections should use OpenSSL
Date Mon, 29 Apr 2019 22:58:45 GMT
steveloughran commented on a change in pull request #784: HADOOP-16050: s3a SSL connections
should use OpenSSL
URL: https://github.com/apache/hadoop/pull/784#discussion_r279569277
 
 

 ##########
 File path: hadoop-common-project/hadoop-common/pom.xml
 ##########
 @@ -334,6 +334,11 @@
       <artifactId>dnsjava</artifactId>
       <scope>compile</scope>
     </dependency>
+    <dependency>
+      <groupId>org.wildfly.openssl</groupId>
+      <artifactId>wildfly-openssl</artifactId>
+      <version>1.0.4.Final</version>
 
 Review comment:
   1. move the declaration of the artifact & version intp `hadoop-project/pom.xml`
   2. import it here and tag as <provided>.
   
   That way it doesn't force a new JAR onto all downstream users (and the shading work to
go with). The stores (abfs, s3a) will then have to explicitly add the wildfly dependency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message