hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gera Shegalov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-16226) new Path(String str) does not remove all the trailing slashes of str
Date Tue, 02 Apr 2019 13:36:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-16226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807764#comment-16807764
] 

Gera Shegalov commented on HADOOP-16226:
----------------------------------------

thanks for the patch [~ajisakaa]. Maybe use a simple double-slash comment to avoid this checkstyle
issue:
{code:java}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java:73:  /**
Pre-compiled regular expressions to detect duplicated slashes */: First sentence should end
with a period. [JavadocStyle]{code}
+1 pending ^

> new Path(String str) does not remove all the trailing slashes of str
> --------------------------------------------------------------------
>
>                 Key: HADOOP-16226
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16226
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Akira Ajisaka
>            Assignee: Akira Ajisaka
>            Priority: Minor
>         Attachments: HADOOP-16226.001.patch
>
>
> new Path(String str) calls Path.normalizePath to normalize the str, however, it does
not remove all the slashes of the str.
> {code:title=Path.java}
>   /**
>    * Normalize a path string to use non-duplicated forward slashes as
>    * the path separator and remove any trailing path separators.
>    *
>    * @param scheme the URI scheme. Used to deduce whether we
>    * should replace backslashes or not
>    * @param path the scheme-specific part
>    * @return the normalized path string
>    */
>   private static String normalizePath(String scheme, String path) {
> {code}
> Javadoc says "remove any trailing path separators", but it removes only one trailing
slash.
> Credit: This issue was found by [~ayushtkn] in HDFS-14369.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message