hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] bharatviswa504 commented on a change in pull request #788: HDDS-1475 : Fix OzoneContainer start method.
Date Thu, 02 May 2019 05:01:53 GMT
bharatviswa504 commented on a change in pull request #788: HDDS-1475 : Fix OzoneContainer start
method.
URL: https://github.com/apache/hadoop/pull/788#discussion_r280289110
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java
 ##########
 @@ -172,7 +176,9 @@ private void stopContainerScrub() {
     if (scrubber == null) {
       return;
     }
-    scrubber.down();
+    if (scrubber.isHalted()) {
 
 Review comment:
   is this should be if (!scrubber.isHalted()) 
   
   As halt is initially set to false, and only it is stopped it is set to true.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message