hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] xiaoyuyao commented on a change in pull request #782: HDDS-1461. Optimize listStatus api in OzoneFileSystem
Date Wed, 15 May 2019 23:03:27 GMT
xiaoyuyao commented on a change in pull request #782: HDDS-1461. Optimize listStatus api in
OzoneFileSystem
URL: https://github.com/apache/hadoop/pull/782#discussion_r284484826
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
 ##########
 @@ -1355,15 +1360,15 @@ public OzoneFileStatus getFileStatus(OmKeyArgs args) throws IOException
{
     String bucketName = args.getBucketName();
     String keyName = args.getKeyName();
 
-    metadataManager.getLock().acquireBucketLock(volumeName, bucketName);
     try {
+      metadataManager.getLock().acquireBucketLock(volumeName, bucketName);
 
 Review comment:
   why do we move the acquireBucketLock inside the try block? The original pattern seems good
to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message