hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] steveloughran commented on a change in pull request #802: HADOOP-16279. S3Guard: Implement time-based (TTL) expiry for entries …
Date Fri, 31 May 2019 18:48:17 GMT
steveloughran commented on a change in pull request #802: HADOOP-16279. S3Guard: Implement
time-based (TTL) expiry for entries …
URL: https://github.com/apache/hadoop/pull/802#discussion_r289510995
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3Guard.java
 ##########
 @@ -147,10 +149,10 @@ public static MetadataStore getMetadataStore(FileSystem fs)
    */
   @RetryTranslated
   public static S3AFileStatus putAndReturn(MetadataStore ms,
-      S3AFileStatus status,
-      S3AInstrumentation instrumentation) throws IOException {
+      S3AFileStatus status, S3AInstrumentation instrumentation,
+      ITtlTimeProvider timeProvider) throws IOException {
 
 Review comment:
   nit; once you go one arg per line (it scales well), don't merge back again...so put instrumentation
back on its own line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message