hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharat Viswanadham (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-16247) NPE in FsUrlConnection
Date Thu, 09 May 2019 22:20:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836742#comment-16836742
] 

Bharat Viswanadham edited comment on HADOOP-16247 at 5/9/19 10:19 PM:
----------------------------------------------------------------------

Patch over all LGTM. Could you add some explanation for the change, it will be easy when someone
is reading the code for the first time. Once this is done, I am +1 with the change.

Thank You [~kpalanisamy] for the fix. (I think now with this patch, it will fix the file scheme
with a relative path, and for rest of the URI's it uses the old code, so it does not break
anything.

 

 

 


was (Author: bharatviswa):
+1. Could you add some explanation for the change, it will be easy when someone is reading
the code. Once this is done, I am +1 with the change.

Thank You [~kpalanisamy] for the fix. (I think now with this patch, it will fix the file scheme
with a relative path, and for rest of the URI's it uses the old code, so it does not break
anything.

 

 

 

> NPE in FsUrlConnection
> ----------------------
>
>                 Key: HADOOP-16247
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16247
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 3.1.2
>            Reporter: Karthik Palanisamy
>            Assignee: Karthik Palanisamy
>            Priority: Major
>         Attachments: HADOOP-16247-001.patch, HADOOP-16247-002.patch, HADOOP-16247-003.patch,
HADOOP-16247-004.patch, HADOOP-16247-005.patch, HADOOP-16247-006.patch, HADOOP-16247-007.patch
>
>
> FsUrlConnection doesn't handle relativePath correctly after the change [HADOOP-15217|https://issues.apache.org/jira/browse/HADOOP-15217]
> {code}
> Exception in thread "main" java.lang.NullPointerException
>  at org.apache.hadoop.fs.Path.isUriPathAbsolute(Path.java:385)
>  at org.apache.hadoop.fs.Path.isAbsolute(Path.java:395)
>  at org.apache.hadoop.fs.RawLocalFileSystem.pathToFile(RawLocalFileSystem.java:87)
>  at org.apache.hadoop.fs.RawLocalFileSystem.deprecatedGetFileStatus(RawLocalFileSystem.java:636)
>  at org.apache.hadoop.fs.RawLocalFileSystem.getFileLinkStatusInternal(RawLocalFileSystem.java:930)
>  at org.apache.hadoop.fs.RawLocalFileSystem.getFileStatus(RawLocalFileSystem.java:631)
>  at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:454)
>  at org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSInputChecker.<init>(ChecksumFileSystem.java:146)
>  at org.apache.hadoop.fs.ChecksumFileSystem.open(ChecksumFileSystem.java:347)
>  at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:899)
>  at org.apache.hadoop.fs.FsUrlConnection.connect(FsUrlConnection.java:62)
>  at org.apache.hadoop.fs.FsUrlConnection.getInputStream(FsUrlConnection.java:71)
>  at java.net.URL.openStream(URL.java:1045)
>  at UrlProblem.testRelativePath(UrlProblem.java:33)
>  at UrlProblem.main(UrlProblem.java:19)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message